-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolate multifield #279
Conversation
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 88.26% 88.28% +0.02%
==========================================
Files 153 153
Lines 9963 10023 +60
==========================================
+ Hits 8794 8849 +55
- Misses 1169 1174 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oriolcg Nice work!
I have added some minor comments.
Can you also add few lines in NEWS.md about the changes/additions?
In the "Added" section, say something like interpolation is now supported also for multifield spaces. In the "Changed" section, say something in the direction that the SingleFieldFESpace
interface has changed. A new function gather_free_and_dirichlet_values!
is added as mandatory and the old one gather_free_and_dirichlet_values
is now optional.
Thanks!
Requested modifications added in the recent commit. |
No description provided.