add get_dof_value_type to FESpacesWithLinearConstraints

[janmodderman]

Hi,

I'm working with AgFEM and complex valued functions and I noticed that the get_dof_value_type seems to be missing from FESpacesWithLinearConstraints. Is there a specific reason this is not implemented?

I added a repro file in the test folder of my Gridap fork.

Kind regards,

Jan

[JordiManyer]

Hi @janmodderman , thanks for the contribution!

I think the API was just missing. I think the way you resolved should work.

However, I suggest the following changes:

• I would remove the test file you added. I don't think it is needed.
• Could you instead simply add a couple lines testing this API in the corresponding test file? I.e test/FESpaces/FESpacesWithLinearConstaintsTests.jl?
• Could you add these changes to NEWS.md?

Can you please do the following changes to the PR?
I'll be happy to accept it then.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (b05bebc) to head (7a8e05d).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1062   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         196      196           
  Lines       23793    23794    +1     
=======================================
+ Hits        21164    21165    +1     
  Misses       2629     2629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[janmodderman]

Hi @JordiManyer,

thanks for the pointers, I made the changes you requested.

[JordiManyer]

Thank you for the contribution!