Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low level optimisations #1043

Merged
merged 7 commits into from
Dec 15, 2024
Merged

Low level optimisations #1043

merged 7 commits into from
Dec 15, 2024

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Oct 29, 2024

We noticed weird allocations happening, related to the creation of Field-related structures.

Log of changes:

  • AffineMap renamed to AffineField.
  • New AffineMap <: Map, doing the same as AffineField without struct allocation.
  • New ConstantMap <: Map, doing the same as ConstantField without struct allocation.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (3b87738) to head (e279910).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/Fields/AffineMaps.jl 95.00% 1 Missing ⚠️
src/Fields/ApplyOptimizations.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
+ Coverage   89.04%   89.05%   +0.01%     
==========================================
  Files         197      197              
  Lines       23887    23902      +15     
==========================================
+ Hits        21270    21286      +16     
+ Misses       2617     2616       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer marked this pull request as ready for review December 15, 2024 21:24
@JordiManyer JordiManyer merged commit 17a4f2e into master Dec 15, 2024
19 checks passed
@JordiManyer JordiManyer deleted the optimisations branch December 15, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant