Optimize xpns_normalize_directory and xpns_is_valid_directory #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xpns_normalize_directory() - instead of calling $_dir variable and change it three times, we just call it once and print it together with /#~/$HOME
xpns_is_valid_directory() - small clean up to improve readability, removing the else to instead use a NOT operator to check if the directory is there or not.
Fixed typo in one comment.
As before, manual testing and smokescreen testing has been done on the code.
But please check so I have not made any mistake.
Cheers