Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize xpns_normalize_directory and xpns_is_valid_directory #184

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

ReDTerraN
Copy link
Contributor

xpns_normalize_directory() - instead of calling $_dir variable and change it three times, we just call it once and print it together with /#~/$HOME

xpns_is_valid_directory() - small clean up to improve readability, removing the else to instead use a NOT operator to check if the directory is there or not.

Fixed typo in one comment.

As before, manual testing and smokescreen testing has been done on the code.
But please check so I have not made any mistake.

Cheers

@greymd greymd merged commit b65fc7c into greymd:master Apr 1, 2023
@greymd
Copy link
Owner

greymd commented Apr 1, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants