This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
allow Graphite instance to properly handle dns based hostnames #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have graphite tcp listeners behind an ELB in AWS (not that is is specific to AWS, just showing our scenario). When the ELB ips change, we start to not receive metrics from Graylog. This change basically just uses the proper Graphite constructor to handle dns in the graphite implementation. More info here dropwizard/metrics#606.
As a side note, it appears at first glance that the Gelf metric reporter may suffer from this issue too. But we don't use that, so I cannot confirm that.