feat(Breadcrumbs): export LinkBreadcrumbsItem & ButtonBreadcrumbsItem types
#1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
smsochneg
force-pushed
the
fix-breadcrumbs-typings
branch
from
d986394 to
d2f9af5
Compare
korvin89
changed the title
smsochneg
force-pushed
the
fix-breadcrumbs-typings
branch
from
d2f9af5 to
80b08f6
Compare
smsochneg
force-pushed
the
fix-breadcrumbs-typings
branch
from
80b08f6 to
f783290
Compare
korvin89
changed the title
LinkBreadcrumbsItem & ButtonBreadcrumbsItem types
korvin89
approved these changes
Mar 21, 2024
amje
requested changes
Mar 21, 2024
| @@ -24,12 +24,12 @@ type BaseBreadcrumbsItem = { | |||
| title?: string; | |||
| }; | |||
|
|
|||
| type LinkBreadcrumbsItem = { | |||
| export type LinkBreadcrumbsItem = { | |||
There was a problem hiding this comment.
Let's rename them to BreadcrumbsLinkItem and BreadcrumbsButtonItem, that's Breadcrumbs name will be at the beginning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.