Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify subscription id matches #51085

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Verify subscription id matches #51085

merged 1 commit into from
Jan 22, 2025

Conversation

bernardjkim
Copy link
Contributor

@bernardjkim bernardjkim commented Jan 15, 2025

A small follow up to the Azure join changes. Teleport should still verify that the attestation subscription ID matches the token claims subscription ID.

Changelog: Improve Azure join validation by verifying subscription ID.

@bernardjkim bernardjkim added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 backport/branch/v17 labels Jan 15, 2025
@bernardjkim bernardjkim requested review from atburke and removed request for ryanclark and camscale January 15, 2025 20:55
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from hugoShaka January 16, 2025 11:56
@bernardjkim bernardjkim added this pull request to the merge queue Jan 17, 2025
@bernardjkim bernardjkim removed this pull request from the merge queue due to a manual request Jan 17, 2025
@bernardjkim bernardjkim removed the no-changelog Indicates that a PR does not require a changelog entry label Jan 22, 2025
@bernardjkim bernardjkim enabled auto-merge January 22, 2025 01:19
@bernardjkim bernardjkim added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit a749106 Jan 22, 2025
44 of 45 checks passed
@bernardjkim bernardjkim deleted the bernard/validate-sub-id branch January 22, 2025 01:41
@public-teleport-github-review-bot

@bernardjkim See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants