This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
pr-support-postman-variables-query #113
Open
thim81
wants to merge
3
commits into
grafana:master
Choose a base branch
from
thim81:pr-support-postman-variables-query
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eep support for "space".
This was referenced Jun 19, 2021
thim81
pushed a commit
to thim81/postman-to-k6
that referenced
this pull request
Jul 24, 2021
…eep support for "space" (grafana#113) Linked to issues grafana#106 and grafana#104
thim81
referenced
this pull request
in apideck-libraries/postman-to-k6
Aug 17, 2021
* Extend support for Postman random functions/dynamic variables (#92) * Fix for unwanted encoding of Postman variables in query string, but keep support for "space" (#113) * Exclude disabled headers when converting requests (#103) * Implement postman replaceIn function * Extended test for url encode handling * Extended test for url encoding of space characters * Extended test to exclude disabled headers when converting requests (#103) * Extended test to include checks for randomPhoneNumber & isoTimestamp * Updated GH workflow actions Co-authored-by: Tim <>
For those that run into the issue of the encoding, I have provided a forked NPM package version that contains a fix for the issue: Replace in your packages.json:
to
This is a forked NPM package, to facilitate other users. The current maintainers are quite overloaded by the acquisition of K6 by Grafana. By forking the repo & package, users can keep using new PR's & (security) fixes. At a later stage the changes can potentially be merged back in the original postman-to-k6 repo. The changelog contains the differences between the original package & the forked version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unwanted encoding of Postman variables in query string, but keep support for "space".
In #93, we introduced
URI.encodeReserved(feature.address.query())
to leverage encoding of query string to handle spaces/+ properly.The
[URI.encodeReserved()](http://medialize.github.io/URI.js/docs.html#static-encodeReserved)
handles the special properties, but also encode the {{}} syntax for Postman variables, which is not desired.In this PR, I made the proposal to remove URI.encodeReserved() but still keep the support of "space" encoding.
In attachment you can find the correct result for a postman collection with 2 query string with {{}}, + and space.