-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install from source instructions #2359
Conversation
From go 1.18 onwards (https://tip.golang.org/doc/go1.18#tools), to install a package from source, we have to use `go install`. Since the command is already available before (from 1.16 onwards) and it's the recommended way to install a package, why not use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #2359 +/- ##
==========================================
+ Coverage 72.71% 74.61% +1.89%
==========================================
Files 184 188 +4
Lines 14571 15124 +553
==========================================
+ Hits 10596 11285 +689
+ Misses 3333 3154 -179
- Partials 642 685 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
From go 1.18 onwards (https://tip.golang.org/doc/go1.18#tools), to install a package from source, we MUST use
go install
.Since the command is already available before (from 1.16 onwards) and it's the recommended way to install a package, why not use it?