Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoAway error on files POST requests #1091

Closed
marlukjanska opened this issue Jul 29, 2019 · 4 comments · Fixed by #1093
Closed

GoAway error on files POST requests #1091

marlukjanska opened this issue Jul 29, 2019 · 4 comments · Fixed by #1093
Labels
bug
Milestone
v0.25.1

Comments

@marlukjanska
Copy link

I was doing a single file upload for number of users initiated via VUs and for some users I was getting the GO AWAY error.
image

After a bit of investigation I've found the following article: https://www.endgame.com/blog/technical-blog/investigating-http2-performance-go

I was wondering if the issue is related to not only our server configuration, but also to the GO http client in k6?
@mstoykov mstoykov added the bug label Jul 29, 2019
@marlukjanska
Copy link
Author

@mstoykov I noticed that you've added a label 'bug'. Do you still need details like k6 version and the script excerpt?
Thanks!

mstoykov added a commit that referenced this issue Jul 30, 2019
@mstoykov
fix: use http.Request's GetBody
3a1fa2c 
This is needed for correct handling of redirects of requests with bodies
and in http2 when the server sends GoAway without an error.

Unfortunately testing the GoAway case turned out to be problematic so it
is left for the future.

Fixes #1091
@mstoykov
Copy link
Contributor

Hi, Sorry, in my original post I said that I did test and couldn't find the bug and was sure we were using GetBody ... as I was pretty sure we have a test to catch another case where it is needed (Posts with redirects, or any request with a body :))
But after nearly two hours of going through code history this is apparently totally not true. I have no idea why I though so ... maybe I though of it at some point and never wrote it down? Either way I am very sorry. At this point

  1. I have reproduced the issue (I needed to have batches of requests or multiple VUs)
  2. I have a patch that fixes it. Hopefully it will get merged ... but I don't know if we are going to put it in 0.25.0 as we are at the later stages of testing it . Maybe 0.25.1 we will see.

as the article suggests you can (for now) up nginx's max requests per http2 connection :)

@mstoykov mstoykov mentioned this issue Jul 30, 2019
Merged
@marlukjanska
Copy link
Author

Thanks for this @mstoykov! :)

@mstoykov
Copy link
Contributor

Thank you, for reporting it :)

@na-- na-- added this to the v0.25.1 milestone Jul 30, 2019
mstoykov added a commit that referenced this issue Aug 2, 2019
@mstoykov
fix: use http.Request's GetBody
1d77e55 
This is needed for correct handling of redirects of requests with bodies
and in http2 when the server sends GoAway without an error.

Unfortunately testing the GoAway case turned out to be problematic so it
is left for the future.

Fixes #1091
mstoykov added a commit that referenced this issue Aug 5, 2019
@mstoykov
fix: use http.Request's GetBody (#1093)
ea694a3 
This is needed for correct handling of redirects of requests with bodies
and in http2 when the server sends GoAway without an error.

Unfortunately testing the GoAway case turned out to be problematic so it
is left for the future.

Fixes #1091
@mstoykov mstoykov mentioned this issue Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.25.1
Development

Successfully merging a pull request may close this issue.

fix: use http.Request's GetBody grafana/k6
3 participants
@mstoykov @na-- @marlukjanska