Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live: Remove (alpha) ability to configure live pipelines #65138

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Live: Remove (alpha) ability to configure live pipelines #65138

merged 3 commits into from
Mar 22, 2023

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Mar 21, 2023 •
edited
Loading

What is this feature?

Removes the alpha feature flag that supported running a custom configured live pipeline. With a k8s model, these configs have a much more obvious config home 🎉 (if/when we choose to revisit)

Why do we need this feature?

Reduce possible support issues -- note that we still implement and support live pipelines, however they are not user configurable.

@ryantxu ryantxu added area/live no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 21, 2023
@ryantxu ryantxu added this to the 9.5.0 milestone Mar 21, 2023
@ryantxu ryantxu changed the title Live: Remove ability to config live pipelines Live: Remove (alpha) ability to configure live pipelines Mar 21, 2023
@grafanabot grafanabot added area/backend type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project area/frontend labels Mar 21, 2023
@ryantxu ryantxu requested a review from ArturWierzbicki March 21, 2023 20:17
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023 •
edited
Loading

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Mar 21, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

@ryantxu ryantxu added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Mar 21, 2023
@ryantxu ryantxu marked this pull request as ready for review March 21, 2023 22:31
@ryantxu ryantxu requested review from joshhunt, a team and chri2547 as code owners March 21, 2023 22:31
@ryantxu ryantxu requested review from yaelleC and jackw and removed request for a team March 21, 2023 22:31
@ryantxu ryantxu requested review from wbrowne, andresmgot, papagian, zserge and suntala and removed request for a team March 21, 2023 22:31
chri2547
chri2547 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM! Thank you.

@ryantxu ryantxu enabled auto-merge (squash) March 22, 2023 17:49
@ryantxu ryantxu merged commit f96637b into main Mar 22, 2023
@ryantxu ryantxu deleted the remove-live-pipeline-configs branch March 22, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturWierzbicki ArturWierzbicki ArturWierzbicki approved these changes

@chri2547 chri2547 chri2547 approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

@jackw jackw Awaiting requested review from jackw jackw was automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne was automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot was automatically assigned from grafana/plugins-platform-backend

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend area/live levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ryantxu @ArturWierzbicki @chri2547 @grafanabot