Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip ConfigMap check #1208

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

marevers
Copy link
Collaborator

Closes #1207

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (47b960e) to head (bb87fe9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   81.93%   81.99%   +0.06%     
==========================================
  Files         137      137              
  Lines       11450    11450              
==========================================
+ Hits         9381     9388       +7     
+ Misses       1538     1533       -5     
+ Partials      531      529       -2     
Flag Coverage Δ
integration-test 60.92% <ø> (+0.40%) ⬆️
k8s-integration-test 58.65% <ø> (+0.03%) ⬆️
oats-test 36.15% <ø> (ø)
unittests 53.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing, thanks @marevers!

@grcevski grcevski merged commit 91f8aeb into grafana:main Sep 30, 2024
10 checks passed
@marevers marevers deleted the skip-configmap-check branch September 30, 2024 21:22
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: Add if condition to avoid the configuration missing check
4 participants