Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git-lfs to track .o files #1183

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Use git-lfs to track .o files #1183

merged 3 commits into from
Sep 19, 2024

Conversation

rafaelroquetto
Copy link
Contributor

This prevents our repo from swelling due to changing binary files.

You may need to run

git lfs install

once in your machine if you run into errors.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (9a23f73) to head (ba23aa4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files         136      136           
  Lines       11497    11497           
=======================================
  Hits         9329     9329           
  Misses       1638     1638           
  Partials      530      530           
Flag Coverage Δ
integration-test 57.01% <ø> (+0.05%) ⬆️
k8s-integration-test 58.85% <ø> (+0.03%) ⬆️
oats-test 35.82% <ø> (ø)
unittests 53.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelroquetto rafaelroquetto force-pushed the git-lfs branch 2 times, most recently from b598d27 to 4355940 Compare September 19, 2024 20:48
@rafaelroquetto rafaelroquetto marked this pull request as ready for review September 19, 2024 20:55
@rafaelroquetto
Copy link
Contributor Author

Rebase on main

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@grcevski
Copy link
Contributor

git lfs install

WDYT about adding small section in our README on this? Like a developer guide for the Beyla contributors?

@rafaelroquetto
Copy link
Contributor Author

Will address the README changes on a separate PR.

@rafaelroquetto rafaelroquetto merged commit cbca5fe into main Sep 19, 2024
8 checks passed
@rafaelroquetto rafaelroquetto deleted the git-lfs branch September 19, 2024 22:28
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
* Delete object files

* Track .o files with git-lfs

* Setup git-lfs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants