-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use git-lfs to track .o files #1183
Conversation
fa049ae
to
6ca4cc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 136 136
Lines 11497 11497
=======================================
Hits 9329 9329
Misses 1638 1638
Partials 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b598d27
to
4355940
Compare
4355940
to
ba23aa4
Compare
Rebase on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
WDYT about adding small section in our README on this? Like a developer guide for the Beyla contributors? |
Will address the README changes on a separate PR. |
* Delete object files * Track .o files with git-lfs * Setup git-lfs
This prevents our repo from swelling due to changing binary files.
You may need to run
once in your machine if you run into errors.