Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mandatory parameters with actionable error message if not set #67

Merged
merged 5 commits into from
Feb 4, 2023
Merged

Introduce mandatory parameters with actionable error message if not set #67

merged 5 commits into from
Feb 4, 2023

Conversation

jjohannes
Copy link
Member

@jjohannes jjohannes commented Jan 18, 2023 •
edited
Loading

Resolves #25

Based on #30

  • Add documentation
  • Add to changelog
  • Add some more tests

@jjohannes jjohannes marked this pull request as ready for review January 20, 2023 13:41
@jjohannes jjohannes force-pushed the jjohannes/better-errors branch from d8eaf85 to cf1cd01 Compare January 26, 2023 07:04
@jjohannes jjohannes force-pushed the jjohannes/better-errors branch from cf1cd01 to 6b76c4e Compare January 26, 2023 07:05
@jjohannes
Copy link
Member Author

This is good to go now.

@jjohannes jjohannes requested a review from britter January 26, 2023 08:32
@jjohannes jjohannes merged commit 3f41d52 into main Feb 4, 2023
@jjohannes jjohannes deleted the jjohannes/better-errors branch February 4, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britter britter Awaiting requested review from britter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give good error if an optional parameter is not set
1 participant
@jjohannes