Update espresso-jshell demo. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build with Java 17. Document -Dorg.graalvm.home argument to espresso-jshell.
fniephaus
reviewed
May 10, 2022
.github/workflows/main.yml
Outdated
| @@ -24,7 +24,7 @@ jobs: | |||
| run: | | |||
| cd espresso-jshell | |||
| ./build-espresso-jshell.sh | |||
| echo "Math.PI" | ./espresso-jshell | |||
| echo "Math.PI" | ./espresso-jshell -Dorg.graalvm.home=$GRAALVM_HOME | |||
There was a problem hiding this comment.
Why does $GRAALVM_HOME need to be passed in? Is there no way to detect this from inside the espresso-jshell?
There was a problem hiding this comment.
Fixed! Now it tries to set/initialize org.graalvm.home and java.home from the GRAALVM_HOME env. variable.
Running just ./espresso-jshell may give the false illusion that the executable is fully standalone.
I added a small section to the README explaining this.
fniephaus
reviewed
May 10, 2022
espresso-jshell/README.md
Outdated
|
|
||
| JShell is a Java read-eval-print loop tool first introduced in the JDK 9, but this demo also shows how to run `jshell` on Java 8. | ||
| JShell is a Java read-eval-print loop tool first introduced in Java 9, this demo also allows to run `jshell` on Java 8. |
There was a problem hiding this comment.
Suggested change
| JShell is a Java read-eval-print loop tool first introduced in Java 9, this demo also allows to run `jshell` on Java 8. | |
| JShell is a Java read-eval-print loop tool first introduced in Java 9, this demo also allows running `jshell` on Java 8. |
There was a problem hiding this comment.
I manually fixes this nits in the latest version.
mukel
force-pushed
the
a2p/espresso-jshell-improvements
branch
2 times, most recently
from
8695c63 to
8dfaa28
Compare
Add section about distribution and clarify the dependency on GraalVM home and/or custom Java home.
mukel
force-pushed
the
a2p/espresso-jshell-improvements
branch
from
d389c68 to
3ea5971
Compare
fniephaus
approved these changes
Jun 20, 2022
olyagpl
reviewed
Jun 20, 2022
| You will build a native executable of `jshell`, that executes dynamically generated bytecode on Espresso. | ||
| This hybrid mode achieves instant startup, beating the vanilla `jshell` in both: time to the first interaction and time to evaluate a simple expression. | ||
| This demo showcases the integration between [GraalVM Native Image](https://www.graalvm.org/reference-manual/native-image/) and [Java-on-Truffle (Espresso)](https://www.graalvm.org/reference-manual/java-on-truffle/). | ||
| It builds a native image of `jshell`, that executes the dynamically generated bytecodes on Espresso. This hybrid mode achieves instant startup, beating the vanilla `jshell` in both: time to the first interaction and time to evaluate a simple expression. |
olyagpl
reviewed
Jun 20, 2022
| This demo showcases the integration between [GraalVM Native Image](https://www.graalvm.org/reference-manual/native-image/) and [Java-on-Truffle (Espresso)](https://www.graalvm.org/reference-manual/java-on-truffle/). | ||
| It builds a native image of `jshell`, that executes the dynamically generated bytecodes on Espresso. This hybrid mode achieves instant startup, beating the vanilla `jshell` in both: time to the first interaction and time to evaluate a simple expression. | ||
|
|
||
| JShell is a Java read-eval-print loop tool first introduced in Java 9, this demo also allows running `jshell` on Java 8. |
There was a problem hiding this comment.
JShell is a Java read-eval-print loop tool first introduced in Java 9, this demo also allows running jshell on Java 8.
JShell is a Java "read-eval-print loop tool" first introduced in Java 9, and this demo also allows running jshell on Java 8.
olyagpl
reviewed
Jun 20, 2022
| It builds a native image of `jshell`, that executes the dynamically generated bytecodes on Espresso. This hybrid mode achieves instant startup, beating the vanilla `jshell` in both: time to the first interaction and time to evaluate a simple expression. | ||
|
|
||
| JShell is a Java read-eval-print loop tool first introduced in Java 9, this demo also allows running `jshell` on Java 8. | ||
| For further discussions and questions please join our `#espresso` channel on the [GraalVM Slack Community](https://graalvm.slack.com/). |
There was a problem hiding this comment.
on the GraalVM slack community > in GraalVM slack community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update for building the demo with Java 17 and documentation improvements.