Add mfa, possible fix for #140 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpailler
reviewed
Apr 23, 2020
gpailler
reviewed
Apr 23, 2020
|
Hi @xbenjii . Thanks a lot for the PR. I tested quickly and it works perfectly. I think adding unit tests for MFA will be complicated so I'm ok to merge the PR without any additional test. Thanks! |
|
@gpailler Thanks! I was a bit concerned with the failing unit tests but then realized they require a bit of setup. Not sure about the flaky ones in CI too, as they sometimes work and other times don't. |
|
Yes, I will check the tests in the CI. They are sometimes failing because of Mega API throttling. |
|
Will merge to master and will fix the UTs |
gpailler
pushed a commit
that referenced
this pull request
Apr 25, 2020
* Add optional MFA token to login requests
gpailler
added a commit
that referenced
this pull request
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies as I'm not well versed in C#, also needs the new tests adding but this should give us a start.
Let me know if you need anything else.