Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new URL format #141

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Added support for new URL format #141

merged 2 commits into from
Apr 7, 2020

Conversation

gpailler
Copy link
Owner

@gpailler gpailler commented Apr 4, 2020

No description provided.

@gpailler gpailler linked an issue Apr 4, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Apr 4, 2020

Codecov Report

Merging #141 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   80.84%   80.94%   +0.09%     
==========================================
  Files          35       35              
  Lines        2026     2052      +26     
  Branches      221      224       +3     
==========================================
+ Hits         1638     1661      +23     
  Misses        324      324              
- Partials       64       67       +3     
Impacted Files Coverage Δ
MegaApiClient/MegaApiClient.cs 78.34% <100.00%> (+0.91%) ⬆️
MegaApiClient/NodeExtensions.cs 87.50% <0.00%> (-2.09%) ⬇️
MegaApiClient/Node.cs 88.13% <0.00%> (-0.85%) ⬇️
MegaApiClient/Stream/MegaAesCtrStream.cs 77.30% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea5ed7...ee21c15. Read the comment docs.

@gpailler gpailler added this to the 1.7.2 milestone Apr 7, 2020
@gpailler gpailler merged commit f548ef1 into master Apr 7, 2020
@schotime
Copy link

schotime commented Apr 7, 2020

When does this make its way to nuget? Just got this issue.

@gpailler
Copy link
Owner Author

gpailler commented Apr 7, 2020

I will try to publish 1.8.0 on Nuget today

@gpailler gpailler deleted the 138-newurl-format branch April 7, 2020 03:13
@gpailler
Copy link
Owner Author

gpailler commented Apr 7, 2020

@schotime https://www.nuget.org/packages/MegaApiClient/1.8.0 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid URI
3 participants