Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

allocator: use ip-only permissions and port-bindings #35

Merged
merged 2 commits into from
May 17, 2019

Conversation

ernado
Copy link
Contributor

@ernado ernado commented May 17, 2019

Fix #34
Relates #33

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #35 into master will decrease coverage by 0.05%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage    73.5%   73.44%   -0.06%     
==========================================
  Files          21       21              
  Lines        1638     1672      +34     
==========================================
+ Hits         1204     1228      +24     
- Misses        310      315       +5     
- Partials      124      129       +5
Impacted Files Coverage Δ
internal/allocator/allocation.go 78.94% <70%> (-5.91%) ⬇️
internal/allocator/allocator.go 81.7% <82.35%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caea8c7...161063d. Read the comment docs.

@ernado ernado merged commit 7d3ba13 into master May 17, 2019
@ernado ernado deleted the ip-only-permissions branch May 17, 2019 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allocator: ignore port for permissions
1 participant