Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: configuration option to disable logo in notification #2810

Closed
apprehensions opened this issue Feb 25, 2024 · 4 comments · Fixed by #2845
Closed

Feature request: configuration option to disable logo in notification #2810

apprehensions opened this issue Feb 25, 2024 · 4 comments · Fixed by #2845
Assignees
@dominikschulz
Milestone
1.15.13

Comments

@apprehensions
Copy link

Hi, i would like to request a small feature in which it is a boolean to disable the logo when sending D-Bus notifications.

The logo is ugly.
@dominikschulz
Copy link
Member

Which logo? The icon?

@apprehensions
Copy link
Author

The notification sent by gopass has a icon attached to it - that one.

@dominikschulz
Copy link
Member

That is an oddly specific feature request, but I have no fundamental concerns.
I'm just wondering if we need to cater for such niche requests at the expense of having more maintenance overhead.

@apprehensions
Copy link
Author

I'll do it then.

@dominikschulz dominikschulz self-assigned this Mar 28, 2024
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 28, 2024
@dominikschulz
[feat] Add option to disable notification icon
f998319 
Fixes gopasspw#2810

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added this to the 1.15.13 milestone Mar 28, 2024
@dominikschulz dominikschulz mentioned this issue Mar 28, 2024
Merged
dominikschulz added a commit that referenced this issue Mar 29, 2024
@dominikschulz
[feat] Add option to disable notification icon (#2845)
9b41761 
* [feat] Add option to disable notification icon

Fixes #2810

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* [chore] Document new config option

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

---------

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
None yet
Projects
None yet
Milestone
1.15.13
Development

Successfully merging a pull request may close this issue.

[feat] Add option to disable notification icon dominikschulz/gopass
2 participants
@dominikschulz @apprehensions