Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add property for allowNonIncrementalDefinition for materialized view #2084

Merged
merged 3 commits into from
Dec 4, 2024
Merged

feat: add property for allowNonIncrementalDefinition for materialized view #2084

merged 3 commits into from
Dec 4, 2024

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Nov 28, 2024 •
edited
Loading

Solves #2083

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Reference

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 28, 2024
@yu-iskw
feat: property for allowNonIncrementalDefinition materialized view
98bc019 
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>

format

Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
@yu-iskw yu-iskw marked this pull request as ready for review November 28, 2024 09:08
@yu-iskw yu-iskw requested review from a team as code owners November 28, 2024 09:08
@yu-iskw yu-iskw requested a review from PhongChuong November 28, 2024 09:08
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024
@chalmerlowe
Copy link
Collaborator

@yu-iskw

Thanks for adding this functionality. I added a couple of comments.
Please take a look.

@Linchin Linchin assigned chalmerlowe and unassigned whuffman36 Dec 2, 2024
yu-iskw and others added 2 commits December 3, 2024 08:32
@yu-iskw @chalmerlowe
Update tests/unit/test_table.py
4f2479b 
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@yu-iskw @chalmerlowe
Update google/cloud/bigquery/table.py
cea663f 
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 2, 2024

@chalmerlowe Thank you for the suggestion. I have taken them.

@yu-iskw yu-iskw requested a review from chalmerlowe December 2, 2024 23:33
@yu-iskw yu-iskw changed the title Add property for allowNonIncrementalDefinition for materialized view feat: add property for allowNonIncrementalDefinition for materialized view Dec 4, 2024
chalmerlowe
chalmerlowe approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@chalmerlowe chalmerlowe merged commit 3359ef3 into googleapis:main Dec 4, 2024
17 checks passed
@release-please release-please bot mentioned this pull request Nov 26, 2024
Merged
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 4, 2024

Thank you for merging this!

@chalmerlowe
Copy link
Collaborator

@yu-iskw

I appreciate your time and effort to add this attribute to the library.

@chalmerlowe chalmerlowe mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@PhongChuong PhongChuong Awaiting requested review from PhongChuong PhongChuong is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yu-iskw @chalmerlowe @whuffman36 @yoshi-kokoro