Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace once with onetime #660

Merged
merged 1 commit into from
Apr 3, 2019
Merged

refactor: replace once with onetime #660

merged 1 commit into from
Apr 3, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Apr 3, 2019

We saw some issues with the latest version of @types/node. Turns out there was a conflict with EventEmitter#once and the types for the once module. This PR just swaps once out for a similar module that does not extend Function.prototype.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested review from bcoe, stephenplusplus and a team April 3, 2019 23:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #660 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files           9        9           
  Lines         869      869           
  Branches       99       99           
=======================================
  Hits          851      851           
  Misses          9        9           
  Partials        9        9
Impacted Files Coverage Δ
src/file.ts 98.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3041d15...37f8529. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #660 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files           9        9           
  Lines         869      869           
  Branches       99       99           
=======================================
  Hits          851      851           
  Misses          9        9           
  Partials        9        9
Impacted Files Coverage Δ
src/file.ts 98.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3041d15...37f8529. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 079f246 into googleapis:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants