Improve TypeScript types (part 4) #402
Conversation
googlebot
added
the
cla: yes
ghost
assigned 
| @@ -1644,7 +1653,8 @@ class Bucket extends ServiceObject { | |||
| }, | |||
| (err, resp) => { | |||
| if (err) { | |||
| callback(err, null, null, resp); | |||
| // tslint:disable-next-line:no-any | |||
| (callback as any)(err, null, null, resp); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Side note - my system tests appear to be passing? |
| getFiles( | ||
| queryOrCallback?: GetFilesOptions|GetFilesCallback, | ||
| callback?: GetFilesCallback): void|Promise<[File[]]> { | ||
| let query = typeof queryOrCallback === 'object' ? queryOrCallback : {}; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
For system-test, it's complaining that it couldn't write to
Okay it's not that reason. But the system-test did start failing from commit 9f65f9d |
|
Samples test has always been flaky on that one test where it complains about unlink |
No description provided.