Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transfer manager MPU sample, adjust defaults, prepare for GA #2318

Merged
merged 5 commits into from
Oct 11, 2023
Merged

feat: add transfer manager MPU sample, adjust defaults, prepare for GA #2318

merged 5 commits into from
Oct 11, 2023

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners October 3, 2023 18:48
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 3, 2023
@snippet-bot
Copy link

snippet-bot bot commented Oct 3, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
/~https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. labels Oct 3, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 3, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

danielduhh
danielduhh reviewed Oct 4, 2023
View reviewed changes
samples/README.md Outdated
@@ -128,6 +128,7 @@ objects to users via direct download.
* [Upload Directory With Transfer Manager](#upload-directory-with-transfer-manager)
* [Upload Encrypted File](#upload-encrypted-file)
* [Upload File](#upload-file)
* [Upload a File in Chunks Utilzing Transfer Manager](#upload-a-file-in-chunks-utilzing-transfer-manager)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Upload a File in Chunks Utilzing Transfer Manager](#upload-a-file-in-chunks-utilzing-transfer-manager)
* [Upload a File in Chunks Utilzing Transfer Manager](#upload-a-file-in-chunks-with-transfer-manager)

for consistency

samples/README.md Outdated
@@ -2086,6 +2087,25 @@ __Usage:__



### Upload a File in Chunks Utilzing Transfer Manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Upload a File in Chunks Utilzing Transfer Manager
### Upload a File in Chunks With Transfer Manager

src/transfer-manager.ts
@@ -33,39 +33,39 @@ const packageJson = require('../../package.json');

/**
* Default number of concurrently executing promises to use when calling uploadManyFiles.
* @experimental
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the PR description to say you're taking off the training wheels?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or split the PRs

@ddelgrosso1 ddelgrosso1 changed the title samples: add transfer manager MPU sample feat: add transfer manager MPU sample, adjust defaults, prepare for GA Oct 4, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2023
@ddelgrosso1
Copy link
Contributor Author

Marking do not merge until we have final approval to go ahead with launch. Please review!

@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2023
@ddelgrosso1 ddelgrosso1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2023
@ddelgrosso1 ddelgrosso1 merged commit a7d09c1 into googleapis:main Oct 11, 2023
@release-please release-please bot mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@danielduhh danielduhh danielduhh approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddelgrosso1 @danielduhh @danielbankhead @yoshi-kokoro