Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for class MultiplexedSession #2201

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

alkatrivedi
Copy link
Contributor

@alkatrivedi alkatrivedi commented Dec 9, 2024

This PR contains the code for the newly introduced class MultiplexedSession.

This PR includes the same changes as PR #2191, which has already been reviewed. The previous PR had to be closed due to restrictions on OwlBot runs, which prevented it from being merged.

@alkatrivedi alkatrivedi requested review from a team as code owners December 9, 2024 11:24
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Dec 9, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@harshachinta
Copy link
Contributor

@alkatrivedi
Please link the other reviewed PR in the description above, along with the reason behind raising another PR.
This will help in future to understand the review comments etc for other developers

@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 9, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 92248c1 into main Dec 9, 2024
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the alka-mux-session branch December 9, 2024 13:00
surbhigarg92 pushed a commit that referenced this pull request Dec 10, 2024
This PR contains the code for the newly introduced class `MultiplexedSession`.

This PR includes the same changes as [PR #2191](https://togithub.com/googleapis/nodejs-spanner/pull/2191), which has already been reviewed. The previous PR had to be closed due to restrictions on OwlBot runs, which prevented it from being merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants