Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: feat: instrument src/ with traces using OpenTelemetry #2087

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: feat: instrument src/ with traces using OpenTelemetry #2087

wants to merge 1 commit into from

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Aug 1, 2024

This change implements tracing of RPC calls using
OpenTelemetry to aid in providing observability.

Fixes #2079

@odeke-em odeke-em requested review from a team as code owners August 1, 2024 07:54
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Aug 1, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
/~https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Aug 1, 2024
@odeke-em odeke-em mentioned this pull request Aug 1, 2024
Closed
@odeke-em odeke-em force-pushed the instrument-with-opentelemetry branch 5 times, most recently from 49bb7b9 to e848ff1 Compare August 4, 2024 00:15
@odeke-em
Copy link
Contributor Author

odeke-em commented Aug 4, 2024

@surbhigarg92 this PR is ready for review!

@odeke-em odeke-em force-pushed the instrument-with-opentelemetry branch 7 times, most recently from 177cb35 to 0292910 Compare August 8, 2024 19:28
@odeke-em odeke-em changed the title feat: instrument src/ with traces using OpenTelemetry DO NOT MERGE: feat: instrument src/ with traces using OpenTelemetry Aug 9, 2024
@odeke-em odeke-em force-pushed the instrument-with-opentelemetry branch from 1a9d9dd to 197828a Compare August 16, 2024 17:17
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Aug 17, 2024
@odeke-em
observability: add base for instrumentation + tests
7084716 
This change adds the scaffolding for instrumentation
along with tests for the tracing mechanisms that'll
be used to trace the entire package.

Built from googleapis#2087
Updates googleapis#2079
@odeke-em odeke-em mentioned this pull request Aug 17, 2024
Merged
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Aug 17, 2024
@odeke-em
observability: add base for instrumentation + tests
ec739ef 
This change adds the scaffolding for instrumentation
along with tests for the tracing mechanisms that'll
be used to trace the entire package.

Built from googleapis#2087
Updates googleapis#2079
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Aug 30, 2024
@odeke-em
observability: add base for instrumentation + tests
8305a0d 
This change adds the scaffolding for instrumentation
along with tests for the tracing mechanisms that'll
be used to trace the entire package.

Built from googleapis#2087
Updates googleapis#2079
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 30, 2024
@odeke-em
observability: add base for instrumentation + tests (#2097)
992baaa 
This change adds the scaffolding for instrumentation along with tests for the
tracing mechanisms that'll be used to trace the entire package.

Built from #2087
Updates #2079
@odeke-em odeke-em force-pushed the instrument-with-opentelemetry branch from 197828a to f509a8a Compare August 30, 2024 08:56
@surbhigarg92 surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 30, 2024
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
9a48feb 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
a4e56f3 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
a477344 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
e0c1dd1 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
0b9aedd 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
b4217d8 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 22, 2024
@odeke-em
feat(observability): add tracing spans to Session
1942877 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
ec48f2c 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): trace Transaction
afa5873 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
8de217a 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
909108d 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
d670cd6 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): trace Database methods
1fd16b4 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): trace Database methods
65ca9f3 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 23, 2024
@odeke-em
feat(observability): trace Database methods
0a205fc 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 30, 2024
@odeke-em
feat(observability): trace Database methods
a34c7b1 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 30, 2024
@odeke-em
feat(observability): add tracing spans to Session
62a9ba8 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 30, 2024
@odeke-em
feat(observability): trace Transaction
4fc8fe7 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Sep 30, 2024
@odeke-em
feat(observability): trace Database methods
eeb628b 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 30, 2024
@odeke-em
feat(observability): trace Database methods (#2119)
1f06871 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates #2079
Built from PR #2087
Updates #2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Oct 1, 2024
@odeke-em
feat(observability): trace Transaction
d8fe92b 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Oct 1, 2024
@odeke-em
feat(observability): trace Transaction
838225e 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Oct 1, 2024
@odeke-em
feat(observability): trace Transaction
9fa7878 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Oct 3, 2024
@odeke-em
feat(observability): trace Transaction
310bf59 
This change adds observability tracing for
Transaction along with tests.

Alsoo while here, added SessionPool.createSessions span.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Oct 3, 2024
@odeke-em
feat(observability): trace Transaction
ac8b6e0 
This change adds observability tracing for
Transaction along with tests.

Alsoo while here, added SessionPool.createSessions span.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
@odeke-em
Copy link
Contributor Author

odeke-em commented Oct 8, 2024

Successfully dissected and no longer necessary!

@odeke-em odeke-em closed this Oct 8, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 8, 2024
@odeke-em
feat(observability): trace Transaction (#2122)
a464bdb 
This change adds observability tracing for
Transaction along with tests.

Updates #2079
Built from PR #2087
Updates #2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this pull request Oct 10, 2024
@odeke-em
feat(observability)): trace Session.create+delete
df93d70 
This change traces Session methods:
* create
* delete

Updaes googleapis#2087
@odeke-em odeke-em mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

all: instrument with traces for observability
3 participants
@odeke-em @surbhigarg92 @yoshi-kokoro