Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in Koa2 interface await next as a function #336

Merged
merged 2 commits into from
Apr 9, 2019
Merged

fix: in Koa2 interface await next as a function #336

merged 2 commits into from
Apr 9, 2019

Conversation

DominicKramer
Copy link
Contributor

Fixes: #335

@DominicKramer DominicKramer requested a review from a team April 9, 2019 16:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2019
@DominicKramer DominicKramer mentioned this pull request Apr 9, 2019
Closed
DominicKramer referenced this pull request Apr 9, 2019
@mike-marcacci @DominicKramer
feat: add Koa2 support (#117)
13e86c9 
This change introduces a Koa2 plugin that is available through the `koa2` property.
The existing Koa1 plugin is still accessed through the `koa` property.

Fixes: #8
@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #336   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files          34      34           
  Lines        1694    1694           
  Branches       76      76           
======================================
  Hits         1628    1628           
  Misses         49      49           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd26cd...f66a56e. Read the comment docs.

ofrobots
ofrobots approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also a test that exercises this code?

@DominicKramer
Copy link
Contributor Author

@ofrobots I'm in the process of creating the tests, and I think they should be samples tests. In particular, I am updating the samples to include samples for the different frameworks. Then I'll update the samples tests to test each sample.

@DominicKramer
Copy link
Contributor Author

Since the sample test changes involve a bit of work, I made an issue (#337) to track it. A follow-up PR will implement that work, and thus I will land this PR. That way, each PR can focus on a specific task.

@DominicKramer DominicKramer merged commit 5838e49 into googleapis:master Apr 9, 2019
@codyzu
Copy link

codyzu commented Apr 10, 2019

Repeating my comment on the issue, this fixed the koa interface. Can you fix the koa2 interface, as was described in the 0.6.2 release changelog (and the name of the PR 😉 )?

codyzu referenced this pull request Apr 10, 2019
@bcoe
Release v0.6.2 (#338)
db8136d
DominicKramer added a commit to DominicKramer/nodejs-error-reporting that referenced this pull request Apr 11, 2019
@DominicKramer
fix: update Koa2 plugin to await next
f27d602 
PR googleapis#336 fixed the Koa plugin, but didn't fix the Koa2 plugin.

Fixes: googleapis#335
@DominicKramer DominicKramer mentioned this pull request Apr 11, 2019
Merged
DominicKramer added a commit that referenced this pull request Apr 11, 2019
@DominicKramer
fix: update Koa2 plugin to await next (#339)
cb6f9ac 
PR #336 fixed the Koa plugin, but didn't fix the Koa2 plugin.

Fixes: #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DominicKramer @codyzu @ofrobots @JustinBeckwith @googlebot