Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new reportMode configuration option #295

Merged

Conversation

DominicKramer
Copy link
Contributor

@DominicKramer DominicKramer commented Jan 8, 2019

Adds the reportMode configuration option. The
ignoreEnvironmentCheck configuration option is now
deprecated, and the reportMode option should be used
instead.

In particular, the reportMode can have one of three values:

  • 'production' (default)
    • Only report errors if NODE_ENV is set to "production".:
  • 'always'
    • Always report errors regardless of the value of NODE_ENV.
  • 'never'
    • Never report errors regardless of the value of NODE_ENV.

Fixes #127

BREAKING CHANGE: The `reportMode` configuration option replaces
the `ignoreEnvironmentCheck` configuration option.

In particular, the `reportMode` can have one of three values:
* 'production' (default)
   - Only report errors if NODE_ENV is set to "production".:
* 'always'
   - Always report errors regardless of the value of NODE_ENV.
* 'never'
   - Never report errors regardless of the value of NODE_ENV.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2019
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants