Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update proto columns test #2845

Merged
merged 3 commits into from
Jan 28, 2024
Merged

test: update proto columns test #2845

merged 3 commits into from
Jan 28, 2024

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Jan 27, 2024 •
edited
Loading

This PR has the following changes in test files

  1. Use try-with-resource block in Proto Columns integration tests to free up resources and sessions.
  2. Add PROTO and ENUM types to testGetAllTypesAsString unit test.

@harshachinta harshachinta requested a review from a team as a code owner January 27, 2024 05:09
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 27, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 27, 2024
@harshachinta harshachinta requested review from olavloite and removed request for olavloite January 27, 2024 09:08
@harshachinta harshachinta changed the title test(spanner): format proto columns test test(spanner): update proto columns test Jan 27, 2024
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2024
@harshachinta harshachinta changed the title test(spanner): update proto columns test test: update proto columns test Jan 28, 2024
@harshachinta harshachinta merged commit 04f72ee into googleapis:main Jan 28, 2024
23 of 24 checks passed
@harshachinta harshachinta mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshachinta @olavloite