Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove partition token from tests #2738

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

olavloite
Copy link
Collaborator

Remove the example partition token from the SQL test scripts, as the tokens are not stable when the encoded classes are changed. E.g. modifying the Value classes will cause these tests to fail with a de-serialization error, as the serialized version in the token no longer corresponds with the version in code.

Fixes the build error in #2736

Remove the example partition token from the SQL test scripts, as the
tokens are not stable when the encoded classes are changed. E.g.
modifying the Value classes will cause these tests to fail with a
de-serialization error, as the serialized version in the token no longer
corresponds with the version in code.

Fixes the build error in #2736
@olavloite olavloite requested review from a team as code owners November 21, 2023 11:24
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 21, 2023
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2023
@olavloite olavloite merged commit 3cba4c6 into main Nov 24, 2023
21 checks passed
@olavloite olavloite deleted the remove-partition-token-from-tests branch November 24, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants