Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds OR filter sample #1032

Merged
merged 14 commits into from
Mar 28, 2023
Merged

docs: adds OR filter sample #1032

merged 14 commits into from
Mar 28, 2023

Conversation

telpirion
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Mar 24, 2023
@kolea2
Copy link
Contributor

kolea2 commented Mar 27, 2023

@jlara310 fyi!

@telpirion telpirion marked this pull request as ready for review March 27, 2023 16:42
@snippet-bot
Copy link

snippet-bot bot commented Mar 27, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
/~https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion requested review from jainsahab and kolea2 March 27, 2023 16:44
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners March 27, 2023 16:45
kolea2
kolea2 reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current changes look good, it would be nice to also have a nested OR example. Will defer to @jlara310 here for requirements

@telpirion
Copy link
Contributor Author

@kolea2 I think we should discuss a nested OR query in a follow-up PR. WDYT?

@telpirion telpirion merged commit e319efa into main Mar 28, 2023
@telpirion telpirion deleted the or-filter branch March 28, 2023 15:58
@release-please release-please bot mentioned this pull request Mar 28, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 30, 2023
@release-please
chore(main): release 2.14.2 (#1033)
ed25a7f 
🤖 I have created a release *beep* *boop*
---


## [2.14.2](https://togithub.com/googleapis/java-datastore/compare/v2.14.1...v2.14.2) (2023-03-29)


### Documentation

* Adds OR filter sample ([#1032](https://togithub.com/googleapis/java-datastore/issues/1032)) ([e319efa](https://togithub.com/googleapis/java-datastore/commit/e319efa402539f0297179d270aa8c8f50e6e3e93))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.6.0 ([#1035](https://togithub.com/googleapis/java-datastore/issues/1035)) ([b2f4cb3](https://togithub.com/googleapis/java-datastore/commit/b2f4cb361afb1398b10edc0fcfe744b414926e07))
* Update gapic-generator-java to 2.16.0 ([8c96c55](https://togithub.com/googleapis/java-datastore/commit/8c96c555159d48f1dc6d53616f0412f60e3095d7))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 left review comments

@jainsahab jainsahab jainsahab approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@telpirion @kolea2 @jainsahab