refactor!: getOptions() no longer accepts GoogleAuthOptions #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
requested review from
JustinBeckwith,
callmehiphop,
ofrobots,
stephenplusplus and
alexander-fenster
JustinBeckwith
approved these changes
Jul 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 84.41% 84.23% -0.18%
==========================================
Files 17 17
Lines 943 945 +2
Branches 210 208 -2
==========================================
Hits 796 796
- Misses 87 88 +1
- Partials 60 61 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 84.41% 84.26% -0.15%
==========================================
Files 17 17
Lines 943 947 +4
Branches 211 210 -1
==========================================
+ Hits 796 798 +2
- Misses 87 88 +1
- Partials 60 61 +1
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Jul 19, 2019
jojonarte
approved these changes
Jul 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
getOptions()no longer accepts GoogleAuthOptions, preventing a variety of side effects caused by credentials that have already been stored in cache.new GoogleAuth({})should instead be used to customize options, or to instantiate multiple clients.fromJSON()has also been made idempotent (it no longer changes the cache).fixes #390