Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use new auth URIs #434

Merged
merged 2 commits into from
Jul 31, 2018
Merged

fix: Use new auth URIs #434

merged 2 commits into from
Jul 31, 2018

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2018
@codecov-io
Copy link

codecov-io commented Jul 31, 2018 •
edited
Loading

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #434   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          15     15           
  Lines         981    981           
  Branches      217    217           
=====================================
  Hits          932    932           
  Misses         49     49
Impacted Files Coverage Δ
src/auth/oauth2client.ts 94.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c2e3d...238664a. Read the comment docs.

crwilcox
crwilcox approved these changes Jul 31, 2018
View reviewed changes
Copy link

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Though it does seem odd we talk to both googleapis.com and oauth2.googleapis.com?

@theacodes
Copy link
Contributor Author

It's what the spec requests of us, so 🤷‍♀️

@theacodes theacodes changed the title Use new auth URIs fix: Use new auth URIs Jul 31, 2018
@theacodes theacodes merged commit e002108 into master Jul 31, 2018
@theacodes theacodes deleted the use-new-auth-uris branch July 31, 2018 22:43
@JustinBeckwith JustinBeckwith mentioned this pull request Aug 28, 2018
Closed
@alexander-fenster alexander-fenster mentioned this pull request Jan 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theacodes @codecov-io @crwilcox @JustinBeckwith @googlebot