feat: add preliminary parsing of parameters #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
force-pushed
the
kvg-params
branch
2 times, most recently
from
82bc245 to
187dbf1
Compare
Yuan325
reviewed
Oct 8, 2024
| type Parameter struct { | ||
| Name string `yaml:"name"` | ||
| Type string `yaml:"type"` | ||
| Description string `yaml:"description"` | ||
| Required bool `yaml:"required"` |
There was a problem hiding this comment.
Side note but I'm thinking having this might help improve latency too(?). Ideally, the LLM will prompt user to provide more information before moving on to the next steps since the field is required.
There was a problem hiding this comment.
I'm removing this because I want to default for all parameters to be required -- I'm unsure of how to handle optional parameters in the SQL query
Yuan325
approved these changes
Oct 8, 2024
duwenxin99
approved these changes
Oct 8, 2024
kurtisvg
pushed a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.1 (2024-10-28) ### Features * Add address and port flags ([#7](#7)) ([df9ad9e](df9ad9e)) * Add AlloyDB source and tool ([#23](#23)) ([fe92d02](fe92d02)) * Add basic CLI ([#5](#5)) ([1539ee5](1539ee5)) * Add basic http server ([#6](#6)) ([e09ae30](e09ae30)) * Add basic parsing from tools file ([#8](#8)) ([b9ba364](b9ba364)) * Add initial cloud sql pg invocation ([#14](#14)) ([3703176](3703176)) * Add Postgres source and tool ([#25](#25)) ([2742ed4](2742ed4)) * Add preliminary parsing of parameters ([#13](#13)) ([27edd3b](27edd3b)) * Add support for array type parameters ([#26](#26)) ([3903e86](3903e86)) * Add toolset configuration ([#12](#12)) ([59b4bc0](59b4bc0)) * Add Toolset manifest endpoint ([#11](#11)) ([61e7b78](61e7b78)) * **langchain-sdk:** Add Toolbox SDK for LangChain ([#22](#22)) ([0bcd4b6](0bcd4b6)) * Stub basic control plane functionality ([#9](#9)) ([336bdc4](336bdc4)) ### Miscellaneous Chores * Release 0.0.1 ([#31](#31)) ([1f24ddd](1f24ddd)) ### Continuous Integration * Add realease-please ([#15](#15)) ([17fbbb4](17fbbb4)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Yuan325
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- * Add address and port flags ([#7](#7)) ([df9ad9e](df9ad9e)) * Add AlloyDB source and tool ([#23](#23)) ([fe92d02](fe92d02)) * Add basic CLI ([#5](#5)) ([1539ee5](1539ee5)) * Add basic http server ([#6](#6)) ([e09ae30](e09ae30)) * Add basic parsing from tools file ([#8](#8)) ([b9ba364](b9ba364)) * Add initial cloud sql pg invocation ([#14](#14)) ([3703176](3703176)) * Add Postgres source and tool ([#25](#25)) ([2742ed4](2742ed4)) * Add preliminary parsing of parameters ([#13](#13)) ([27edd3b](27edd3b)) * Add support for array type parameters ([#26](#26)) ([3903e86](3903e86)) * Add toolset configuration ([#12](#12)) ([59b4bc0](59b4bc0)) * Add Toolset manifest endpoint ([#11](#11)) ([61e7b78](61e7b78)) * **langchain-sdk:** Add Toolbox SDK for LangChain ([#22](#22)) ([0bcd4b6](0bcd4b6)) * Stub basic control plane functionality ([#9](#9)) ([336bdc4](336bdc4)) * Release 0.0.1 ([#31](#31)) ([1f24ddd](1f24ddd)) * Add realease-please ([#15](#15)) ([17fbbb4](17fbbb4)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary parsing of parameters. Currently it only supports 4 types: string, int, float32, and bool. Almost certainly we will need to introduce more complicated parsing configuration (to handle objects and arrays), but my initial attempts got quickly complicated, so I simplified in the short term.
This also makes 2 breaking changes to config.yaml: