fix: Use quotes around extreme int64 values #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON numbers are only really expected to be precise as far as IEEE-754 64-bit binary floating point numbers; that means precision is lost for very large integers. The proto3 JSON specification says that 64-bit integers should be encoded as strings, although numeric values can be parsed. Fixes googleapis#1205
vchudnov-g
approved these changes
Sep 6, 2022
|
Yup, it looks like it is. Thanks for the LGTM - merging now. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.26.0](https://togithub.com/googleapis/gapic-showcase/compare/v0.25.0...v0.26.0) (2023-03-07) ### Features * **go:** Update Go version to 1.19 ([#1225](https://togithub.com/googleapis/gapic-showcase/issues/1225)) ([d4b108e](https://togithub.com/googleapis/gapic-showcase/commit/d4b108e16dc91c0ea6d4dec3dca4d3270d3bf47a)) ### Bug Fixes * Build assets for darwin/arm64 ([#1267](https://togithub.com/googleapis/gapic-showcase/issues/1267)) ([0833a57](https://togithub.com/googleapis/gapic-showcase/commit/0833a579131c14582b053f26698fdfe93e465d87)) * Export showcase_v1beta1.yaml from BUILD.bazel to support external GAPIC generation ([#1223](https://togithub.com/googleapis/gapic-showcase/issues/1223)) ([5076348](https://togithub.com/googleapis/gapic-showcase/commit/507634898e208b7ff88784e4ec5f0efd22bff9ab)) * Handle x-http-method-override for PATCH as POST ([#1262](https://togithub.com/googleapis/gapic-showcase/issues/1262)) ([4070ce3](https://togithub.com/googleapis/gapic-showcase/commit/4070ce331bd5e852ccb2f4f2267dce80a9dda9c4)) * Use quotes around extreme int64 values ([#1206](https://togithub.com/googleapis/gapic-showcase/issues/1206)) ([c9d9ff1](https://togithub.com/googleapis/gapic-showcase/commit/c9d9ff191bfd72fe8563625be4074fe4659585d6)), closes [#1205](https://togithub.com/googleapis/gapic-showcase/issues/1205) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON numbers are only really expected to be precise as far as IEEE-754 64-bit binary floating point numbers; that means precision is lost for very large integers.
The proto3 JSON specification says that 64-bit integers should be encoded as strings, although numeric values can be parsed.
Fixes #1205