Use PHP-Scoper to prefix production dependencies in a third-party directory #696
Conversation
…ectory, and generate optimized autoloader.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…sed in Google library).
…kit-wp into fix/612-prefix-dependencies
…kit-wp into fix/612-prefix-dependencies
.travis.yml
Outdated
| - npm install || exit 1 | ||
| - composer install | ||
| - docker run --rm -v "$PWD:/app" composer install | ||
| - | | ||
| if [[ "$PHP" == "1" ]] || [[ "$JS" == "1" ]] || [[ "$SNIFF" == "1" ]]; then | ||
| npm install -g gulp-cli |
There was a problem hiding this comment.
These things should run in the install phase of the build rather than before_script I think
| Finder::create() | ||
| ->files() | ||
| ->ignoreVCS( true ) | ||
| ->notName( '/LICENSE|.*\\.md|.*\\.dist|Makefile|composer\\.json|composer\\.lock/' ) |
There was a problem hiding this comment.
| ->notName( '/LICENSE|.*\\.md|.*\\.dist|Makefile|composer\\.json|composer\\.lock/' ) | |
| ->notName( '/LICENSE|.*\\.md|.*\\.dist|Makefile|composer\\.(json|lock)/' ) |
There was a problem hiding this comment.
Looks like this change should still be made.
Co-Authored-By: Evan Mattson <evan.mattson@10up.com>
There was a problem hiding this comment.
There is a tweak @aaemnnosttv proposed here I think should be made before merging, but aside from that looks good.
Since he said they weren't blocking I say this is good-to-go, but if you could see about his last suggested change (the composer.lock regex bit) that'd be great!
|
@tofumatt I committed that change already, not sure why it still shows up, but it's done :) |
Summary
Addresses issue #612
Note that after this is merged, we need to update the contributor guidelines on getting started to includecomposer global require humbug/php-scoperRelevant technical choices
scoper.inc.phpconfiguration file.autoload_files.phpfile generated by the original autoloader and load them in a bit different way. This at least ensures we don't have to manually maintain that list of files.Checklist