-
Notifications
You must be signed in to change notification settings - Fork 15
Add yapf linter step and make CI explicit #116
Conversation
omg you're so fast that I got whiplash! would it make sense to fix whatever errors yapf raises in the same PR? |
Since there are so many lint errors, let me open a new PR to deal with it. |
sounds great, thanks for fighting the beast! looking forward to seeing the green checkmark! 💪 |
To ease the burden, is there a way to add an excludelist that initially has all the files, then we remove them one-by-one in PRs? (new files would not be added to the list) |
That's a good idea. let me add the excludelist for linter, and defeat the lint errors one-by-one :) |
After PyPI recently changed their client webauth scheme (1 hr ago), |
Done. may I merge this? @zaqqwerty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jae, LGTM
Fix #44
Before this PR, CI only showed two steps only in this
Conversation
Tab.This made us frustrated to check the real cause of the error because it's implicit. So, this PR makes the CI steps explicit in this
Conversation
tab, which also enables the parallel executions of the whole CI steps.Also, it adds
yapf
linter