Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier lint md workflow #144

Closed
wants to merge 12 commits into from
Closed

Conversation

wolf99
Copy link
Contributor

@wolf99 wolf99 commented Jan 13, 2023

Alternative to #129 that uses markdownlint-cli action, this PR instead uses a Prettier action.

Initially implemented with Prettier argument --check to not change files in place, so as to experiment with the configuration.
Intention to later switch from --check to --write.

@wolf99 wolf99 marked this pull request as draft January 13, 2023 19:53
@wolf99
Copy link
Contributor Author

wolf99 commented Jan 13, 2023

OK, I'm out of ideas for how to use actions/checkout properly for this.
Will wait for a response on actions/checkout#1108

@G-Rath
Copy link
Collaborator

G-Rath commented Jan 13, 2023

fwiw, I don't think it's worth the complexity of trying to have CI do commits on PRs anyway 🤷

@wolf99
Copy link
Contributor Author

wolf99 commented Jan 13, 2023

Thanks @G-Rath, if no good answer in while from the issue I raised with actions/checkout, then I'll adjust the PR to not make the commit but instead fail if linting is needed.

another-rex pushed a commit that referenced this pull request Dec 18, 2023
This uses `prettier` to format non-Go files using my (opinioned) config;
note that I'd recommend having `proseWrap` set to `always` but that has
a _huge_ number of changes so I'll do a seperate PR for that.

Resolves #144
Resolves #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants