oboe: stop stream if callback requests it #323
Conversation
Stop in a separate thread for AAudio before Q. Call stop directly for OpenSL ES. Possible fix for #277
src/aaudio/AudioStreamAAudio.cpp
Outdated
| @@ -263,6 +282,7 @@ Result AudioStreamAAudio::requestStart() { | |||
| return Result::OK; | |||
| } | |||
| } | |||
| setDataCallbackEnabled(true); | |||
There was a problem hiding this comment.
I don't get this - why is dataCallbackEnabled always set to true? what about stream which use nonblocking read/writes?
|
|
||
| setDataCallbackEnabled(true); |
There was a problem hiding this comment.
As previous comment. Not sure why the stream should always be using callbacks.
There was a problem hiding this comment.
Enabled just means it is not disabled. It does not mean it will be used. But that is confusing. I will clarify or modify the code.
There was a problem hiding this comment.
I cleaned up the enable and also refactored requestStart for OpenSL ES.
src/opensles/AudioStreamOpenSLES.cpp
Outdated
| } | ||
| if (stopStream) { | ||
| requestStop(); | ||
| // launchStopThread(); |
There was a problem hiding this comment.
Thanks. I removed it.
Simplify locking in OpenSL requestStart.
|
Fixes #61 |
|
Sorry, your question slipped through the net... You should still be able to use You can stop the stream at any time by calling Please open a new issue referencing this one if you're still experiencing problems. |
|
Additionally, you can check the result of |
Stop in a separate thread for AAudio before Q.
Call stop directly for OpenSL ES.
Possible fix for #277