-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add channel mask support for API 32. #1548
Conversation
For AAudio, channel mask support was added in API 32. In this change, channel mask support is added in Oboe for API 32. Fixes #1409.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. This was much bigger than I thought.
I downloaded this PR and ran it on Raven. |
For TEST INPUT, if I select ChannelCount=3 then I get 3 independent mic inputs. |
For input case, "2.1" and "Tri" are not valid selection. In that case, getting error is WAI. Selecting channel count as 3 will be translated to index mask, which is a different case and will work. |
Is there a case when they would be valid? I am guessing no. system/audio.h distinguishes between AUDIO_CHANNEL_IN_* and AUDIO_CHANNEL_OUT_*. |
Yes, our previous max channel count is 8. I have uploaded a new patch to address this. |
Yes, audio.h distinguishes between input and output channel. But when AIDL is introduced, we decided not to distinguish input and output channel mask AAudioStreamParameters::validateChannelMask for the valid input channel mask. For instance, 2.0.2 is a valid one. We can add that in the aaudio documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scrolling channel boxes are nice.
For AAudio, channel mask support was added in API 32. In this change,
channel mask support is added in Oboe for API 32.
Fixes #1409.