Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an array of callback buffer for OpenSL ES. #1245

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Use an array of callback buffer for OpenSL ES. #1245

merged 3 commits into from
Aug 2, 2021

Conversation

flamme
Copy link
Collaborator

@flamme flamme commented Apr 15, 2021 •
edited
Loading

Fixes #1165

@tguilbert-google
Copy link
Member

I am deferring to philburk@ for the review.

@tguilbert-google tguilbert-google removed their request for review April 15, 2021 18:55
philburk
philburk requested changes Apr 19, 2021
View reviewed changes
src/opensles/AudioStreamOpenSLES.h Outdated Show resolved Hide resolved
philburk
philburk requested changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right idea given the API for OpenSL ES.
The current implementation is immediately writing to the AudioTrack buffer.
So the old code was able to run without glitching.
But having one memory buffer per node is more correct.

src/opensles/AudioInputStreamOpenSLES.cpp Outdated Show resolved Hide resolved
src/opensles/AudioOutputStreamOpenSLES.cpp Outdated Show resolved Hide resolved
@philburk philburk assigned flamme and unassigned philburk Jul 27, 2021
philburk
philburk approved these changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to Squash and Merge any time.

@philburk philburk merged commit 7933a7e into main Aug 2, 2021
@philburk philburk deleted the fix-1165-opensles-callbackbuffer branch August 2, 2021 21:35
@philburk philburk mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees

@flamme flamme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSL ES should use an array of callback buffers
3 participants
@flamme @tguilbert-google @philburk