Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioStreamBuffered::onDefaultCallback() should call writeNow() #154

Closed
philburk opened this issue Jul 5, 2018 · 2 comments
Closed

AudioStreamBuffered::onDefaultCallback() should call writeNow() #154

philburk opened this issue Jul 5, 2018 · 2 comments
Assignees
@philburk
Milestone
v1.0

Comments

@philburk
Copy link
Collaborator

philburk commented Jul 5, 2018

There is a FIXME in the code that needs to be reviewed. A unit test would help.
@philburk philburk added this to the v1.0 milestone Jul 5, 2018
@philburk philburk self-assigned this Jul 5, 2018
@dturner
Copy link
Collaborator

dturner commented Aug 7, 2018

Phil to investigate independently

@philburk
Copy link
Collaborator Author

philburk commented Oct 3, 2018 •
edited
Loading

After analyzing the code, I think calling write() is correct. The readNow() zeros out the unfilled part of the buffer. There is no similar behavior for write. So there is now writeNow().

BTW, when studying the code I found Issue #233

@philburk philburk closed this as completed Oct 3, 2018
@philburk philburk mentioned this issue Oct 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@dturner @philburk