Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underflow for OpenSL ES blocking writes sound worse than necessary #233

Closed
philburk opened this issue Oct 3, 2018 · 1 comment
Closed

Underflow for OpenSL ES blocking writes sound worse than necessary #233

philburk opened this issue Oct 3, 2018 · 1 comment
Assignees
@philburk
Milestone
v1.0

Comments

@philburk
Copy link
Collaborator

philburk commented Oct 3, 2018

The FifoBuffer::readNow() method was zeroing the beginning of the buffer when an underflow occurred. It should have zeroed the end of the buffer.
@philburk philburk self-assigned this Oct 3, 2018
@philburk philburk added this to the v1.0 milestone Oct 3, 2018
This was referenced Oct 3, 2018
Closed
Merged
@philburk
Copy link
Collaborator Author

philburk commented Oct 5, 2018

Fixed in #234

@philburk philburk closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@philburk