Fix build with bison >= 3.7.5 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The YYUSE macro was renamed to YY_USE in bison 3.7.5; we might as well avoid using it altogether and cast the unused variable to void instead. Fixes the following linker error: /usr/bin/ld: kafel/libkafel.a(libkafel.o): in function `kafel_yyerror': arm_syscalls.c:(.text+0x6984): undefined reference to `YYUSE'
foutrelis
changed the title
foutrelis
changed the title
|
Thanks for the fix! :) |
10 tasks
picnoir
added a commit
to picnoir/nixpkgs
that referenced
this pull request
Apr 23, 2021
The nsjail build has been broken since the 3.7.5 bison bump:
/nix/store/(...)/bin/ld: kafel/libkafel.a(libkafel.o):
in function `kafel_yyerror':
arm_syscalls.c:(.text+0x6833): undefined reference to `YYUSE'
The issue is coming from kafel and has been fixed upstream. More infos
at: google/kafel#28.
Kafel being distributed through a git submodule in the nsjail repo, we
can't directly fetchpatch the fix from Github. We had to manually
modify the said patch to add a /kafel prefix.
We'll need to remove this patch for the next nsjail version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following linker error: