-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading self-links: more compact, customizable, and reusable #1831
Merged
chalin
merged 4 commits into
google:main
from
chalin:chalin-im-header-anchor-link-2024-02-03
Feb 8, 2024
Merged
Heading self-links: more compact, customizable, and reusable #1831
chalin
merged 4 commits into
google:main
from
chalin:chalin-im-header-anchor-link-2024-02-03
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
added
enhancement
New feature or request
UX
design/style
Front-end site design / styling
cleanup/refactoring
labels
Feb 4, 2024
chalin
force-pushed
the
chalin-im-header-anchor-link-2024-02-03
branch
from
February 4, 2024 00:41
2fbb5db
to
b94a36b
Compare
chalin
changed the title
Header anchor links: more compact, customizable & reusable
Heading links: more compact, customizable, and reusable
Feb 4, 2024
chalin
force-pushed
the
chalin-im-header-anchor-link-2024-02-03
branch
from
February 4, 2024 01:13
2ebbf5c
to
c4394f4
Compare
4 tasks
chalin
changed the title
Heading links: more compact, customizable, and reusable
Heading self-links: more compact, customizable, and reusable
Feb 4, 2024
chalin
force-pushed
the
chalin-im-header-anchor-link-2024-02-03
branch
4 times, most recently
from
February 7, 2024 08:43
ebedec8
to
4b9eebd
Compare
Ok, I've reimplemented the feature to be opt in. PTAL @LisaFC @deining @fekete-robert et al. |
chalin
force-pushed
the
chalin-im-header-anchor-link-2024-02-03
branch
from
February 7, 2024 09:48
4b9eebd
to
490bf86
Compare
fekete-robert
approved these changes
Feb 7, 2024
chalin
force-pushed
the
chalin-im-header-anchor-link-2024-02-03
branch
2 times, most recently
from
February 8, 2024 19:35
cc1c12c
to
0a357d5
Compare
chalin
force-pushed
the
chalin-im-header-anchor-link-2024-02-03
branch
from
February 8, 2024 19:38
0a357d5
to
e36df9c
Compare
Thanks for the review and approval @fekete-robert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup/refactoring
design/style
Front-end site design / styling
enhancement
New feature or request
UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onmouse*
attributes, replacing them with CSS of equivalent functionality#
. This makes the headings much more compact..td-heading-self-link
Preview of user-guide addition (and the new heading-self-link implementation):
Screenshots (narrow display)
Footnotes
I forced the display of the anchor symbol so you can see it in the "before" image. ↩