NPM dependencies: Update font-awesome package to include new twitter logo #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
chalin
force-pushed
the
new-twitter-logo
branch
from
21cdfc4 to
4b9c05d
Compare
deining
suggested changes
Nov 28, 2023
There was a problem hiding this comment.
Thanks for your PR!
This PR takes care of the npm dependency. We have font-awesome as module dependency too, which also needs to be updated.
@venkyvajrala: can you add this missing part to the PR as well, please?
|
@deining Updated module dependency for font-awesome library. |
This was referenced Dec 6, 2023
chalin
force-pushed
the
new-twitter-logo
branch
from
4aca01d to
9fdcbdc
Compare
chalin
force-pushed
the
new-twitter-logo
branch
from
9fdcbdc to
183df8f
Compare
chalin
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1753