Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more translation to ar.toml #1292

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

mboukhalfa
Copy link
Contributor

This PR translates English lines to Arabic in ar.toml

@google-cla
Copy link

google-cla bot commented Oct 23, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mboukhalfa mboukhalfa force-pushed the Arabic-translation/mohammed branch from 757c15d to 9c159e3 Compare October 23, 2022 20:58
@deining deining added the i18n Internationalization / Localization label Nov 1, 2022
@deining
Copy link
Collaborator

deining commented Nov 1, 2022

Thanks for your contribution which looks good to me.

I realized however, that two texts are missing in the arabic translation file ar.toml:

docsy/i18n/en.toml

Lines 19 to 21 in d9bf98b

# Used in sentences such as "All Tags"
[ui_all]
other = "all"

docsy/i18n/en.toml

Lines 40 to 41 in d9bf98b

[post_view_this]
other = "View page source"

Can you please add and translate these two texts, too? Thanks in advance.

@mboukhalfa mboukhalfa force-pushed the Arabic-translation/mohammed branch from 9c159e3 to 92106ed Compare November 1, 2022 20:05
@mboukhalfa
Copy link
Contributor Author

Thanks for your contribution which looks good to me.

I realized however, that two texts are missing in the arabic translation file ar.toml:

docsy/i18n/en.toml

Lines 19 to 21 in d9bf98b

# Used in sentences such as "All Tags"
[ui_all]
other = "all"

docsy/i18n/en.toml

Lines 40 to 41 in d9bf98b

[post_view_this]
other = "View page source"

Can you please add and translate these two texts, too? Thanks in advance.

Ops, I missed that thanks

@deining deining force-pushed the Arabic-translation/mohammed branch from fbbd9ce to d87a44f Compare November 2, 2022 20:04
@deining deining merged commit 33fd6ea into google:main Nov 2, 2022
@deining
Copy link
Collaborator

deining commented Nov 2, 2022

LGTM. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization / Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants