Make nested types work #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes don't have a corresponding macro defined anywhere, so they will cause compilation errors if we leave them in. This bug was exposed by a recent change in autocxx-bindgen that added `bindgen_original_name` attributes for nested types; this is why autocxx-bindgen was temporarily pinned to version 0.58.3, which does not contain those changes. Because the bug is now fixed, this change also updates autocxx-bindgen to 0.58.4.
This is in preparation for being able to use it for types as well as functions.
We use the `bindgen_original_type` attribute emitted by autocxx-bindgen to refer to the correct C++ type in generated C++ and Rust code. For details, see google#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
bindgen_original_typeattribute emitted by autocxx-bindgen to refer to the correct C++ type in generated C++ and Rust code.For details, see #115.
Fixes #115.