Remove code for unused template param detection. #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported two different ways by bindgen; I can't think of a reason we'd need both. Disable one of those ways. Specifically, it should be: * Reported by callback when announcing a type; * Reported by wrapping any instances of that type in bindgen_marker_UnusedTemplateParam<T> We'll disregard the second one.
…ng-template-param-annotation
We aren't able to find the error here - possibly this is being generated correctly.
This reverts commit 4bc062b.
…ng-template-param-annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported two different ways by bindgen; I can't think of a reason we'd need both. Disable one of those ways.
Specifically, it should be:
We'll disregard the second one. Then we don't need to upstream it as part of #124.