Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure cred file is created with a predictable name #130

Merged
merged 1 commit into from
Feb 3, 2022
Merged

feat: ensure cred file is created with a predictable name #130

merged 1 commit into from
Feb 3, 2022

Conversation

sethvargo
Copy link
Member

Fixes #123

@sethvargo sethvargo requested a review from a team as a code owner February 3, 2022 14:57
@sethvargo sethvargo force-pushed the sethvargo/predictable_path branch from e1e7b58 to 5323b36 Compare February 3, 2022 14:58
@sethvargo sethvargo enabled auto-merge (squash) February 3, 2022 14:58
bharathkkb
bharathkkb reviewed Feb 3, 2022
View reviewed changes
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and not related to this change but from the logs it looks like we were not building the action in CI and using the older distributable

auth/.github/workflows/test.yml

Lines 53 to 61 in 3b7fb59

- uses: 'actions/setup-node@v2'
with:
node-version: '16.x'
- id: 'auth-default'
name: 'auth-default'
uses: './'
with:
credentials_json: '${{ secrets.AUTH_SA_KEY_JSON }}'

src/utils.ts Show resolved Hide resolved
@sethvargo sethvargo force-pushed the sethvargo/predictable_path branch from 5323b36 to 975c0f3 Compare February 3, 2022 17:42
@sethvargo
Copy link
Member Author

@bharathkkb fixed the build issue

@sethvargo sethvargo merged commit 48c46e6 into main Feb 3, 2022
@sethvargo sethvargo deleted the sethvargo/predictable_path branch February 3, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help us avoid credential leak into containers - Use a default credential file path
2 participants
@sethvargo @bharathkkb