Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gci: fix cgo #5274

Merged
merged 2 commits into from
Jan 1, 2025
Merged

gci: fix cgo #5274

merged 2 commits into from
Jan 1, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 1, 2025

I rewritten the implementation to follow the same implementation as other formatters.

The current Analyzer implementation doesn't work as expected.

Fixes #5273

@ldez ldez added bug Something isn't working area: cgo Related to CGO or line directives labels Jan 1, 2025
@ldez ldez added this to the next milestone Jan 1, 2025
@ldez ldez requested a review from bombsimon January 1, 2025 17:02
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/golinters/gci/gci.go Show resolved Hide resolved
@ldez ldez merged commit ffb15ca into golangci:master Jan 1, 2025
15 checks passed
@ldez ldez deleted the fix/cgo-gci branch January 1, 2025 18:02
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cgo Related to CGO or line directives bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected gci linter error after upgrading to v1.63.0
2 participants